* Revisit #648 #2489

PWagner1 · 2025-09-13T12:03:55Z

giduac · 2025-09-15T05:00:27Z

Will be testing during this week

giduac

A strange thing is that the InternalPanel is selectable. if you click that area. When the title-bar is clicked the KForm is selected. The latter should be the case when any part of the form is clicked, the form is selected in the properties window.

I cant see any improvement in this branch atm.
Also controls cannot be added, as was the case before.

devenv_hAwOMPRKTp.mp4

Please have this corrected before requesting a review.
Thanks.

PWagner1 · 2025-09-16T17:52:46Z

@PWagner1

A strange thing is that the InternalPanel is selectable. if you click that area. When the title-bar is clicked the KForm is selected. The latter should be the case when any part of the form is clicked, the form is selected in the properties window.

I cant see any improvement in this branch atm. Also controls )cannot be added, as was the case before.

devenv_hAwOMPRKTp.mp4
Please have this corrected before requesting a review. Thanks.

@giduac

I don't know why, but it seems to work correctly in some instances but not others...

giduac · 2025-09-16T17:59:25Z

@PWagner1
A strange thing is that the InternalPanel is selectable. if you click that area. When the title-bar is clicked the KForm is selected. The latter should be the case when any part of the form is clicked, the form is selected in the properties window.
I cant see any improvement in this branch atm. Also controls )cannot be added, as was the case before.
devenv_hAwOMPRKTp.mp4
Please have this corrected before requesting a review. Thanks.

@giduac

I don't know why, but it seems to work correctly in some instances but not others...

Why does the menu interfere with the controls area / internalPanel...

PWagner1 · 2025-09-16T18:01:36Z

@PWagner1
A strange thing is that the InternalPanel is selectable. if you click that area. When the title-bar is clicked the KForm is selected. The latter should be the case when any part of the form is clicked, the form is selected in the properties window.
I cant see any improvement in this branch atm. Also controls )cannot be added, as was the case before.
devenv_hAwOMPRKTp.mp4
Please have this corrected before requesting a review. Thanks.

@giduac
I don't know why, but it seems to work correctly in some instances but not others...

Why does the menu interfere with the controls area / internalPanel...

@giduac

That, I don't understand, as it never touches it?

PWagner1 · 2025-09-16T18:13:48Z

@giduac

Yesssssssssssssss......... fixed it!!!!!!!!!!!

giduac · 2025-09-17T06:57:23Z

@giduac

Yesssssssssssssss......... fixed it!!!!!!!!!!!

I'd like to take this a bit further.

Why does the themed menu react to (mouse) input that is not in the title-bar?
Another approach to look at: can the themed menu be made to not react to input while the form is in design mode. That can make the code in KInternalpanel redundant. And that code will run a lot since the panel is at the core of kform.

giduac · 2025-09-17T07:10:20Z

@PWagner1

And controls cant be added normally nor can they be moved across the form.
https://github.com/user-attachments/assets/ecaf5425-f95d-446f-9116-dff4c0d25912

PWagner1 · 2025-09-17T07:51:48Z

@PWagner1

And controls cant be added normally nor can they be moved across the form. https://github.com/user-attachments/assets/ecaf5425-f95d-446f-9116-dff4c0d25912

@giduac

This is pretty much of a hit and miss...

Screen.Recording.2025-09-17.084932.mp4

…lkit into 648-revisited-V100

giduac · 2025-09-18T05:19:19Z

@PWagner1
And controls cant be added normally nor can they be moved across the form. https://github.com/user-attachments/assets/ecaf5425-f95d-446f-9116-dff4c0d25912

@giduac

This is pretty much of a hit and miss...

Screen.Recording.2025-09-17.084932.mp4

So disabling worked at designtime, nice.

There have been quite a few edits to try to get this fixed. Which most of those are likely unnecessary. So best is to clean all this out and get it nice and tidy. When going over the code I think there are also some stale code blocks.

After that I'd like to go over the code and have a look at the need for nullability on vars/instances to reduce null checks.
A question mark doesn't look like much but will result in a full null check under the hood. So there's a bit to gain here.

# EDIT:

Or maybe better take a new branch from Alpha to lose all the changes.
And add the part that turns the menu off...

And:

Since this all happens in the form instance the Form.DesignModeproperty can be used directly and don't need this code block.
Several (not all) components/controls have this property handy...

    /// <summary>
    /// Robust design mode detection that works both at design time and runtime.
    /// </summary>
    private bool IsInDesignMode()
    {
        // Multiple checks for robust designer mode detection
        return LicenseManager.UsageMode == LicenseUsageMode.Designtime ||
               Site?.DesignMode == true ||
               (Site?.Container?.Components?.OfType<Control>().Any(c => c.Site?.DesignMode == true) == true);
    }```

PWagner1 · 2025-09-18T06:33:32Z

@PWagner1
And controls cant be added normally nor can they be moved across the form. https://github.com/user-attachments/assets/ecaf5425-f95d-446f-9116-dff4c0d25912

@giduac
This is pretty much of a hit and miss...
Screen.Recording.2025-09-17.084932.mp4

So disabling worked at designtime, nice.

There have been quite a few edits to try to get this fixed. Which most of those are likely unnecessary. So best is to clean all this out and get it nice and tidy. When going over the code I think there are also some stale code blocks.

After that I'd like to go over the code and have a look at the need for nullability on vars/instances to reduce null checks. A question mark doesn't look like much but will result in a full null check under the hood. So there's a bit to gain here.

# EDIT:

Or maybe better take a new branch from Alpha to lose all the changes. And add the part that turns the menu off...

And:

Since this all happens in the form instance the Form.DesignModeproperty can be used directly and don't need this code block. Several (not all) components/controls have this property handy...
    /// <summary>
    /// Robust design mode detection that works both at design time and runtime.
    /// </summary>
    private bool IsInDesignMode()
    {
        // Multiple checks for robust designer mode detection
        return LicenseManager.UsageMode == LicenseUsageMode.Designtime ||
               Site?.DesignMode == true ||
               (Site?.Container?.Components?.OfType<Control>().Any(c => c.Site?.DesignMode == true) == true);
    }```

Not necessary, as systemmenu is now disabled at design time. That's what the code block is for.

giduac · 2025-09-24T04:49:47Z

@PWagner1

Testing...

ShowOnAltSpace set to false still shows the themed menu.
https://github.com/user-attachments/assets/4b6ee149-7a4c-4824-9161-4a2f1233aa2f

giduac · 2025-09-24T05:05:54Z

@PWagner1

Custom menu items created in the designer
Are not added to the menu at runtime.
Also those are not serialised into the designer source.
Also: add 1 item to the menu. Then remove it and try adding it again. This results in an error.
Also tried to mutate the menu items at run-time.
There the items are always inserted above Close.

PWagner1 · 2025-09-24T07:30:43Z

@giduac

Please retry

giduac · 2025-09-25T05:02:39Z

@PWagner1

Getting close...

System menu opens on the wrong location using ALT+SPACE

TestForm_G8wLek6eq6.mp4

Custom menu items created in the designer, are not added to the menu at runtime.
Those are not serialised into the designer source.
Problem in the designer: add 1 item to the menu. Then remove it and try adding it again. This results in an error.

devenv_8vnWDfnM55.mp4

PWagner1 · 2025-09-26T10:26:59Z

@Smurf-IV or @giduac

Would you mind taking a look at the serialisation, as a extra pair of eyes would help. I'm appearing to go round in circles.

…/Standard-Toolkit into 648-revisited-V100

PWagner1 · 2025-09-29T14:15:30Z

@giduac

Are we good to merge? I've opened #2530 for future improvement

giduac · 2025-09-29T17:32:27Z

@giduac

Are we good to merge? I've opened #2530 for future improvement

I will test first...

giduac · 2025-09-29T19:58:38Z

@giduac

Are we good to merge? I've opened #2530 for future improvement

OK in this state it won't pose a problem to the user and you have time to get it sorted.
One thing: In the testform page you made for the system menu there are still several references to the custom menu item which will inhibit a build within vstudio.... I just ran into that...

PWagner1 · 2025-09-30T05:51:04Z

@giduac
Are we good to merge? I've opened #2530 for future improvement

OK in this state it won't pose a problem to the user and you have time to get it sorted. One thing: In the testform page you made for the system menu there are still several references to the custom menu item which will inhibit a build within vstudio.... I just ran into that...

@giduac

Just taken out the references, so it should now build

giduac · 2025-09-18T17:24:31Z

Source/Krypton Components/Krypton.Toolkit/General/Definitions.cs

 /// 
 /// The definitions in this file provide the foundational types and contracts that enable
 /// the flexible theming, styling, and behavior customization capabilities of the Krypton Toolkit.
 /// </summary>


@PWagner1
cc.: @tobitege, @Smurf-IV, @KamaniAR & @lesandrog

Suppressing the warning here is imo not a good way to go about this.
The XML Doc tags have none for namespaces. Maybe this works now but could create a problem in the future.
Also the text is not about the namespace but about the content of the file.

My Suggestion is to go for the standard block comment to tell something about the file contents.
Like:

/* * Core definitions file for the Krypton Toolkit containing interfaces, enums, and type definitions * used throughout the Krypton UI component library. * * This file contains: * - Core interfaces for content values, button specifications, and context menu providers * - Enumerations for UI states, orientations, styles, and behaviors * - Type definitions for palette states, button styles, and layout specifications * - Constants and enumerations for message boxes, icons, and theme types * * The definitions in this file provide the foundational types and contracts that enable * the flexible theming, styling, and behavior customization capabilities of the Krypton Toolkit. */

giduac · 2025-09-18T17:54:32Z

Source/Krypton Components/Krypton.Toolkit/Values/SystemMenuValues.cs

    private bool _showOnIconClick;
-    private ThemedSystemMenuItemCollection? _customMenuItems;
+    private SystemMenuItemCollection? _customMenuItems;
    #endregion


private ThemedSystemMenuItemCollection? _customMenuItems;

_customMenuItems is assigned in the constructor.

After that the reference is never reassigned

In that case _customMenuItems does not need to be nullable.

And all these null checks are redundant.

giduac · 2025-09-18T18:53:05Z

Source/Krypton Components/Krypton.Toolkit/Controls Toolkit/KryptonForm.cs

-                // Refresh the themed system menu to reflect the new state
-                _themedSystemMenuService?.ThemedSystemMenu?.Refresh();
+                // Refresh the system menu to reflect the new state
+                _systemMenuService?.SystemMenu?.Refresh();


_systemMenuService?.SystemMenu?.Refresh();

SystemMenu is a non nullable property so the null check is redundant.
There multiple occurences in KForm of this,

giduac · 2025-09-18T19:03:03Z

Source/Krypton Components/Krypton.Toolkit/Controls Toolkit/KryptonForm.cs

    private Rectangle _lastGripClientRect = Rectangle.Empty;
    private Rectangle _lastGripWindowRect = Rectangle.Empty;
+    private readonly KryptonSystemMenuService? _systemMenuService;
+    private SystemMenuValues _systemMenuValues;


private SystemMenuValues _systemMenuValues;
Is assigned once in the constructor and is non nullable declared. After that there are no reassignements
Can be declared as read-only.

This field is null checked a lot in KForm.

giduac · 2025-09-18T19:22:18Z

Source/Krypton Components/Krypton.Toolkit/Controls Toolkit/KryptonForm.cs

+    /// <para>If detection fails or is ambiguous, returns False (assumes runtime) to ensure
+    /// application functionality is preserved over designer convenience.</para>
+    /// </remarks>
+    private bool IsInDesignMode() =>


Maybe a condensed version of this...

PWagner1 · 2025-09-30T06:56:36Z

@giduac

All of your feedback has now come up... GH WT****?

Screen.Recording.2025-09-30.075549.mp4

giduac · 2025-09-30T06:59:02Z

@giduac

All of your feedback has now come up... GH WT****?

Screen.Recording.2025-09-30.075549.mp4

PR meltdown.....

tomdobing · 2025-10-02T12:21:10Z

@PWagner1 / @giduac just for clarity - The issue of internal panel not allowing the drop of controls is this now resolved?

as i have update nightly to the latest yet i still cannot drag controls onto the form. Only way i can is by dropping them into the titlebar dragging back onto the form and then rightclicking. however it still will not show the control at run time.

Maybe i missed something i am not sure. any helpc

PWagner1 · 2025-10-02T17:21:24Z

@PWagner1 / @giduac just for clarity - The issue of internal panel not allowing the drop of controls is this now resolved?

as i have update nightly to the latest yet i still cannot drag controls onto the form. Only way i can is by dropping them into the titlebar dragging back onto the form and then rightclicking. however it still will not show the control at run time.

Maybe i missed something i am not sure. any helpc

Hi @tomdobing

Would you mind testing this branch? https://github.com/Krypton-Suite/Standard-Toolkit/tree/alpha-kform-internalpanel-designer-fix

cc. @giduac

PWagner1 · 2025-10-03T07:11:50Z

Hi @tomdobing

I can confirm that it is fixed, but .NET is the culprit for the designer bug. Please follow this workaround.

cc. @Smurf-IV & @giduac

PWagner1 and others added 7 commits September 13, 2025 13:01

* Test

dabe127

* #2480

3ca5f5d

Merge branch 'alpha' into 648-revisited-V100

92e903e

* Tidy up

9a541d0

* Fix warnings

be6803a

Update StartScreen.Designer.cs

5f79c96

Merge branch 'alpha' into 648-revisited-V100

2dc42ba

PWagner1 mentioned this pull request Sep 14, 2025

[Bug]: KryptonForm's 'InternalPanel' designer issues #2480

Closed

Merge branch 'alpha' into 648-revisited-V100

1b1f091

giduac requested changes Sep 16, 2025

View reviewed changes

PWagner1 added 2 commits September 16, 2025 19:20

* Fixes

854ea55

* Refinements

ca56c9a

Merge branch 'alpha' into 648-revisited-V100

2d07546

PWagner1 added 4 commits September 17, 2025 09:16

* Cleanup

7d90cc0

Update KryptonForm.cs

55a7333

Merge branch 'alpha' of https://github.com/Krypton-Suite/Standard-Too…

47a6f47

…lkit into 648-revisited-V100

* Fix merge fallout chaos

56beb92

PWagner1 added 3 commits September 18, 2025 07:34

* Tidy up code

9b194ab

Update KryptonForm.cs

37aa85d

Update KryptonForm.cs

55202cf

PWagner1 added 2 commits September 24, 2025 08:21

* Fixes for feedback

0c3895a

* ShowOnAltSpace fixes

3db0b6e

PWagner1 and others added 3 commits September 25, 2025 07:47

* Serialisation

b3fc775

* Serialisation

baa087f

Merge branch 'alpha' into 648-revisited-V100

f046228

PWagner1 and others added 5 commits September 26, 2025 11:27

* More serialisation

34d4b0e

Merge branch '648-revisited-V100' of https://github.com/Krypton-Suite…

8f404e8

…/Standard-Toolkit into 648-revisited-V100

Update KryptonSystemMenu.cs

30eb45f

Merge branch 'alpha' into 648-revisited-V100

b7575cc

* Removed custom menu item feature

15554f8

Smurf-IV approved these changes Sep 29, 2025

View reviewed changes

* Fix TestForm

13fc6f4

giduac approved these changes Sep 30, 2025

View reviewed changes

giduac merged commit ed2ac72 into alpha Sep 30, 2025
2 checks passed

PWagner1 removed their assignment Sep 30, 2025

PWagner1 deleted the 648-revisited-V100 branch September 30, 2025 06:21

* Revisit #648 #2489

* Revisit #648 #2489

Uh oh!

Conversation

PWagner1 commented Sep 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

giduac commented Sep 15, 2025

Uh oh!

giduac left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PWagner1 commented Sep 16, 2025

Uh oh!

giduac commented Sep 16, 2025

Uh oh!

PWagner1 commented Sep 16, 2025

Uh oh!

PWagner1 commented Sep 16, 2025

Uh oh!

giduac commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

giduac commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PWagner1 commented Sep 17, 2025

Uh oh!

giduac commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

# EDIT:

And:

Uh oh!

PWagner1 commented Sep 18, 2025

# EDIT:

And:

Uh oh!

giduac commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

giduac commented Sep 24, 2025

Uh oh!

PWagner1 commented Sep 24, 2025

Uh oh!

giduac commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PWagner1 commented Sep 26, 2025

Uh oh!

PWagner1 commented Sep 29, 2025

Uh oh!

giduac commented Sep 29, 2025

Uh oh!

giduac commented Sep 29, 2025

Uh oh!

PWagner1 commented Sep 30, 2025

Uh oh!

giduac Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

giduac Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

giduac Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

giduac Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

giduac Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PWagner1 commented Sep 30, 2025

Uh oh!

giduac commented Sep 30, 2025

Uh oh!

tomdobing commented Oct 2, 2025

Uh oh!

PWagner1 commented Sep 13, 2025 •

edited

Loading

giduac left a comment •

edited

Loading

giduac commented Sep 17, 2025 •

edited

Loading

giduac commented Sep 17, 2025 •

edited

Loading

giduac commented Sep 18, 2025 •

edited

Loading

giduac commented Sep 24, 2025 •

edited

Loading

giduac commented Sep 25, 2025 •

edited

Loading

PWagner1 commented Oct 2, 2025 •

edited

Loading